Skip to content

Commit

Permalink
Fix bug where assets_path wasn't added to some watermark frames
Browse files Browse the repository at this point in the history
  • Loading branch information
alecpl committed Oct 4, 2017
1 parent 305900b commit 0ad7e4c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ CHANGELOG Roundcube Webmail
- Fix missing cursor in HTML editor on mail reply (#5969)
- Fix (again) bug where image data URIs in css style were treated as evil/remote in mail preview (#5580)
- Fix bug where mail search could return empty result on servers without SORT capability (#5973)
- Fix bug where assets_path wasn't added to some watermark frames

RELEASE 1.3.1
-------------
Expand Down
11 changes: 7 additions & 4 deletions program/include/rcmail_output_html.php
Original file line number Diff line number Diff line change
Expand Up @@ -1138,10 +1138,13 @@ protected function xml_command($matches)

// we are calling a class/method
if (($handler = $this->object_handlers[$object]) && is_array($handler)) {
if ((is_object($handler[0]) && method_exists($handler[0], $handler[1])) ||
(is_string($handler[0]) && class_exists($handler[0])))
$content = call_user_func($handler, $attrib);
$external = true;
if (is_callable($handler)) {
// We assume that objects with src attribute are internal (in most
// cases this is a watermark frame). We need this to make sure assets_path
// is added to the internal assets paths
$external = empty($attrib['src']);
$content = call_user_func($handler, $attrib);
}
}
// execute object handler function
else if (function_exists($handler)) {
Expand Down

0 comments on commit 0ad7e4c

Please sign in to comment.