Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with non-interactable tabs on Android #126

Closed
wants to merge 1 commit into from

Conversation

janusw
Copy link
Collaborator

@janusw janusw commented Oct 8, 2024

This should fix #84 and #120 AFAICS. Testing and feedback welcome.

@roubachof What was the original reason for using TapGestureRecognizer only on WinUI, but not on other platforms? On Android it actually seems to work well (and better than the tap command effects). Any reason why we couldn't use it on iOS as well? That would make the implementation more generic and require less platform-specific code ...

@roubachof
Copy link
Owner

no, I use a native ripple effect on android and a color effect on ios.
It has to do with the effect being unregistered or the android implementation being deffective. Need to check platform code.

@roubachof roubachof closed this Oct 8, 2024
@janusw
Copy link
Collaborator Author

janusw commented Oct 8, 2024

no, I use a native ripple effect on android and a color effect on ios.

Alright, I see.

It has to do with the effect being unregistered or the android implementation being deffective. Need to check platform code.

Could you maybe have a quick look into this? You know this code way better than I do ...

@janusw
Copy link
Collaborator Author

janusw commented Oct 9, 2024

no, I use a native ripple effect on android and a color effect on ios.

Some more comments on this:

  • IMHO a simple but working implementation would be preferable to a fancy but broken one ;)
  • according to this, handlers should be preferred over effects in MAUI
  • maybe the TouchBehavior from MAUI CommunityToolkit could be used to replace the touch effects?

@janusw
Copy link
Collaborator Author

janusw commented Oct 9, 2024

* maybe the TouchBehavior from MAUI CommunityToolkit could be used to replace the touch effects?

or alternatively, the ripple effect could be implemented via a handler, as shown here:
https://stackoverflow.com/questions/77456691/how-can-i-get-the-tap-gesture-animation-in-a-maui-control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAUI] Bottom Tabs Not Interactable After Suspending Android App
2 participants