Add a global CI job for infrastructure packages #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
approved these changes
Jun 27, 2024
| build_environment_variables: | ||
| PYTHONWARNINGS: 'ignore:pkg_resources::' | ||
| build_tool: colcon | ||
| build_tool_test_args: '--event-handler console_stderr- console_cohesion+ --executor parallel --python-testing pytest --pytest-args -k "not test_spell_check" --packages-skip superflore' |
There was a problem hiding this comment.
Is superflore being skipped because tests aren't passing on HEAD?
There was a problem hiding this comment.
That's correct. I think at least some of them may need a functioning container engine.
There was a problem hiding this comment.
cc @robwoolley since you have been getting superflore tests up and running.
nuclearsandwich
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent for this job is to regularly build and test the bleeding edge of all of our infrastructure packages. Because these packages aren't part of any ROS distribution, the development tip is not regularly tested.
As we narrow in on a blessed development environment for our infrastructure packages as a whole (what linters/plugins are expected), we can add more packages to this job and tweak the build/test args to expand our coverage. This is a pretty good starting point, but there are notably absent packages like
ros_buildfarmitself, which doesn't work due to setuptools compatibility.Requires: ros-infrastructure/ros_buildfarm#1056
Requires: ros-infrastructure/ros_buildfarm#1057Staging deployment: https://build.test.ros2.org/job/ci__infra_ubuntu_noble_amd64/