Refactor and split test_service into test_{service,client} #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service/client instrumentation isn't currently complete (see #143), so the
test_service
tracing test wasn't really maintained. To be more in line with other tests:test_service_ping
andtest_service_pong
test nodes to have only 1 client in thetest_sevice_ping
node and only 1 service in thetest_service_pong
node. The goal is simply to get a ping->pong communication and then shut down. Therefore, unlike pubs/subs, we only need 1 pair of client/service: we can simply do a request->response. Also, simplify the code a bit.test_service.py
to only assert service-related events; nothing client-related. This is more in line withtest_publisher.py
/test_subscription.py
.test_client.py
and only assert client-related events; nothing service-related. This means that the test is quite simple.Requires ros2/rclcpp#2670 to fix a missing tracepoint trigger.
action-ros-ci-repos-override: https://gist.githubusercontent.com/christophebedard/49dc900164d67c8bc994a9104e7fd0b1/raw/fb5b5ef110c38880fd5ce71a21102e0776343058/ros2.repos