Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit context fields test to test_ros2trace #107

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Add explicit context fields test to test_ros2trace #107

merged 1 commit into from
Apr 8, 2024

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Apr 6, 2024 •
edited
Loading

The test_unknown_context_field test expected an error on unknown context fields, but there was no test for a normal/non-error case.

Also, modify assertTraceContains to be able to expect fields.

@christophebedard christophebedard self-assigned this Apr 6, 2024
fujitatomoya
fujitatomoya approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@christophebedard
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit c9160c6 into rolling Apr 8, 2024
7 of 9 checks passed
@christophebedard christophebedard deleted the christophebedard/add-test-ros2trace-test-context branch April 8, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@christophebedard christophebedard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophebedard @fujitatomoya