Added tampered buffer deserialization tests #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for deserialization of a corrupted buffer.
The message type has been chosen on purpose to be
UnboundedSequences
in order to check the fixes on ros2/rmw_fastrtps#505 and eProsima/Fast-CDR#98.They perform the following sequence:
2^32 - 1
elements and either allocation errors or access beyond the end of the serialized buffer may occurThese tests fail with
rmw_fastrtps_cpp
andrmw_fastrtps_dynamic_cpp
unless Fast CDR is updated to v1.0.19 and ros2/rmw_fastrtps#505 is appliedThese new tests fail locally on
rmw_cyclonedds
, so it may need to be updated