Fix humble parameter config for compressed depth image transport publisher #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ijnek tagging for visibility, I'm not sure if there is more I need to do / fix since I haven't really contributed much 😅 |
ahcorde
requested changes
May 16, 2024
| @@ -45,7 +45,7 @@ | |||
| #include <vector> | |||
| #include <sstream> | |||
|
|
|||
| constexpr int kDefaultPngLevel = 9; | |||
| constexpr int kDefaultPngLevel = 3; | |||
There was a problem hiding this comment.
is there any reason to change the default behaviour ? I would like to avoid change this because it might affect other users.
The other change LGTM
There was a problem hiding this comment.
The default was changed in future releases so I just matched them, and when I tested it a while back I think I remember 9 compression giving me problems (I think taking too long that it was reducing the frame rate). I would need to run it again to check, but since it's a param we can just change it back
ahcorde
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the humble version of compressed depth image transport so it is at least use-able. See #89.
Not needed for Iron or Rolling releases since the parameter structure changes and is then fixed.