Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2] reconfigurable transport scoped parameters for CompressedDepthPublisher #145

Merged

Commits on Apr 27, 2023

  1. Declare depth compression params in a per-topic namespace

    Marcel Zeilinger authored and bmegli committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    020be42 View commit details
    Browse the repository at this point in the history
  2. reconfigurable transport scoped parameters for CompressedDepthPublisher

    - runtime reconfiguration
    - <image>.<transport>.<param> as future replacement of  <image>.<param>
      - e.g. `image.compressedDepth.png_level` instead of `image.png_level`
    - support both ways for now
    - emit deprecation warnings on setting through non-transport scoped parameter
    - synchronize deprecated changes to new ones
      - this is necessary for dynamic reconfigure
    - add ROS1 like ranges for parameters (min/max)
    - some cleanup
      - remove unnecessary includes, using statements, etc.
    
    Default png_level was left the same as for compressed_image_transport
    - this is OpenCV default (3)
    - the deprecated paramterer name clashes here with compressed_image_transport
    - I don't really want to consider if there is a race between plugin loading for default value
    - side notes:
      - in ROS2 default was 9
        - 9 is not usable for real-time processing on most machines
      - in ROS1 default is now 1
      - 3 is typically usable for real-time processing
      - this should probably be made even with ROS1 after removing deprecated parameters
    
    Related to ros-perception#140
    Builds up on ros-perception#110
    bmegli committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    dfdf48b View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2023

  1. compressed_depth based coment example using png_level

    Co-authored-by: Kenji Brameld <[email protected]>
    bmegli and ijnek authored Apr 30, 2023
    Configuration menu
    Copy the full SHA
    32e8b81 View commit details
    Browse the repository at this point in the history
  2. compressed_depth based coment deprecated example using png_level

    Co-authored-by: Kenji Brameld <[email protected]>
    bmegli and ijnek authored Apr 30, 2023
    Configuration menu
    Copy the full SHA
    136eb45 View commit details
    Browse the repository at this point in the history
  3. comment color.image_raw. + compressed_depth + .png_level

    Co-authored-by: Kenji Brameld <[email protected]>
    bmegli and ijnek authored Apr 30, 2023
    Configuration menu
    Copy the full SHA
    d500eae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9844501 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. adjust deprecated warning with "ambiguous"

    For:
    - compressed_depth_image_transport
    - compressed_image_transport
    bmegli committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1e7bad4 View commit details
    Browse the repository at this point in the history
  2. remove excess deprecated value reads for compressed transports

    For already declared attributes those reads do nothing
    bmegli committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b604913 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Configuration menu
    Copy the full SHA
    992cc64 View commit details
    Browse the repository at this point in the history