[rolling] reconfigurable transport scoped parameters for CompressedSubscriber #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- runtime reconfiguration - <image>.<transport>.<param> as future replacement of <image>.<param> - e.g. `image.compressed.mode` instead of `image.mode` - support both ways for now - emit deprecation warnings on setting through non-transport scoped parameter - synchronize deprecated changes to new ones - this is necessary for dynamic reconfigure Similar changes will be needed for: - other transports Related to ros-perception#140
|
Considering the duplicated code between publisher and subscriber is going to be removed after deprecated parameter are removed in the future, these changes look good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompressedSubscriber
#108 is simply reading mode before image decoding
Some CompressedPublisher cleanup to have common structure
In the screenshot:
Design Decisions
Constant parameter table thrown back to
compressed_publisher.cppandcompressed_subscriber.cppI decided not to overthink this too much.
After deprecated parameters are removed in the future the only thing left will be constant table with definitions.