add transport scoped parameters for CompressedPublisher #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #140
This is #142 re-targeted at rolling
Changes
Compared to #142
tiff.xdpi
)runtime reconfiguration
rolling supports runtime reconfiguration (reads params at the beginning of publish)
This forced us to synchronize deprecated values to correct ones. Otherwise deprecated values would not be used.
I purposefully synchronize only in deprecated -> non-deprecated direction.
nested attributes
Handler emitting deprecation warnings now handles nested attributes (like
tiff.xdpi
)warnings
Now not emitted if new value was already set like deprecated one.
This will not emit warnings if somebody is using default values (not setting anything)
structure
All constants (parameter definition)
Next Steps
Again, this only targets
compressed_publisher
If we agree on direction I can rework the rest along.
Refactoring
If generalizing for multiple transports:
compressed_publisher_cfg.h
declareParameter
may become free function shared by all transportsonParameterEvent
may become free function shared by all transportsIn particular header and implementation would be further cleared from (common) parameter related code