Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth image decompression resulting in all NaN values. #89

Open
abstanton opened this issue Feb 22, 2022 · 5 comments
Open

Depth image decompression resulting in all NaN values. #89

abstanton opened this issue Feb 22, 2022 · 5 comments

Comments

@abstanton
Copy link

Hi, we are facing an issue where on decompression of a 32FC1 depth image compressed with the compressedDepth plugin, every pixel is NaN. A bag file including a few depth messages before compression can be found here . Has anyone faced a similar problem/have a possible solution? This is really hindering our ability to record/review data at the moment so any help would be very appreciated.

Steps to reproduce:

  1. Run bag file with qos override for camera/depth/depth_registered topic to system default
  2. Run ros2 run image_transport republish raw compressedDepth --ros-args --remap /in:=/camera/depth/depth_registered --remap /out/compressedDepth:=/camera/depth/depth_registered/compressedDepth
  3. Run ros2 run image_transport republish compressedDepth raw --ros-args --remap /in/compressedDepth:=/camera/depth/depth_registered/compressedDepth --remap /out:=/camera/depth/depth
  4. Try and visualise the /camera/depth/depth topic, it will be all NaN so will show as a black image, whereas visualising /camera/depth/depth_registered will show a normal depth image.
@siliconlad
Copy link

siliconlad commented Feb 22, 2022

This is happening to us on ROS 2 Galactic on Ubuntu 20.04.

@jonselling
Copy link

It seems like it was (correctly) fixed in the PR for rolling, can we make an update to humble that just updates this line to use the correct config field?

@bmegli
Copy link
Contributor

bmegli commented Mar 8, 2024

Apart from development rolling, the fix is released in Iron

{ //DEPTH_QUANTIZATION - Depth value at which the sensor accuracy is 1 m (Kinect: >75)
ParameterValue((double)100.0),


I agree that at least this minimal fix is necessary to make humble compression functional.

Mentioning maintainers may capture their attention, @ijnek

@ijnek
Copy link
Member

ijnek commented Mar 15, 2024

Yes! A PR woulld be greatly appreciated for this bug fix.

@mhubii
Copy link

mhubii commented Jun 24, 2024

what is the state of this? I was unfortunately relying on compressed depth functionality with no time for a check.

I am also receiving this error: #106 (comment)

Running Ubuntu 22.04 ROS 2 Humble

Update: I built this package from source and depth compression works well. Maybe a new binary release is necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants