-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds scaling option for calibrators #783
base: noetic
Are you sure you want to change the base?
Conversation
Signed-off-by: delivers-26 <[email protected]>
Signed-off-by: delivers-26 <[email protected]>
Signed-off-by: delivers-26 <[email protected]>
@JWhitleyWork, |
@onurtore Thanks for the PR. However, this pretty significantly changes the behavior of the node. I'm OK with the idea that you're presenting but not with the change in the default behavior. Instead, can you check for the existence of the parameter and, if it isn't defined, use the current behavior? |
Signed-off-by: delivers-26 <[email protected]>
Hi @JWhitleyWork , While I fixed that with my latest commit, I belive the current version of the code is a little bit problematic, see the scale parameter is the scale of the input image relative to 640x480, however this behaviour does not look like intuitive, I believe when someone use such parameter it would expect making scale >1.0 scales up the input image, however the current implementation decreases it, so maybe I should change how the scale param calculated. Anyway, I belive this version is still acceptable if its okay, I can create a seperate PR for what I mentioned |
@JWhitleyWork, |
1 similar comment
@JWhitleyWork, |
New personal computers can handle the input without the need for downscaling, this commit makes it parametric.