New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix coalesce_interval_ms not working correctly #296

Open

sathyas2023 wants to merge 1 commit into ros-drivers:ros2 from sathyas2023:fix_coalesce_interval_ms_parameter_has_no_effect

sathyas2023 commented Jan 2, 2025

The coalesce_interval_ms parameter doesn't get used properly. Spamming axis events (ex: spinning joysticks) causes rates to get very high.

should_publish is being incorrectly overwritten to true in the event loop function.

The PR makes the event loop logic the same as game_controller_node which did not have this issue from my testing.


          fix coalesce_interval_ms not working correctly

5ee71d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet