fix: Remove correction for off-by-one error in igraph

[krlmlr]

Upstream: igraph/rigraph#1606.

The igraph 2.1.2 release is waiting in CRANs queue. Kindly requesting permission to release with short notice. Can you push a targets update soon, or do we need compatibility code?

Similar problems in drake.

[wlandau]

5bcc7e2 fixes the check in targets. Is this this definitely the direction you are going for the 2.1.2 release? In igraph/rigraph#1606, the discussion seems undecided.

[wlandau]

Closing this PR since 5bcc7e2 is compatible with both current and upcoming graph.

[krlmlr]

Thanks for taking this on. Instead of testing versions, can you test the behavior? Perhaps with a simple graph A -> B. That would be the safest for all cases.

Does drake indeed have the same problem?

[wlandau]

can you test the behavior

done in f872e3a

Does drake indeed have the same problem?

Yup, working on the same patch (EDIT: done).

Anything else left to do before I submit these packages?

[krlmlr]

Thank you so much for your super-fast response! Looks good to me. If you submit today-ish, I can wait with the igraph release until then so that this will be as non-disruptive as possible.

[wlandau]

Submitted both just now. drake is accepted, targets will need a revdep check.

[krlmlr]

Thanks again for the super-fast response, igraph 2.1.2 is on CRAN too.