Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parallel tests + avoid partial matching #1384

Closed
wants to merge 2 commits into from
Closed

Conversation

olivroy
Copy link

@olivroy olivroy commented Nov 21, 2024

Prework

Summary

Speed up test by using testthat parallel (on CI -2 minutes for testing on ubuntu (10min44 to 9min29) + avoid partial matching (caught by having this set in Rprofile)

  options(
    warnPartialMatchArgs = TRUE,
    warnPartialMatchDollar = TRUE,
    warnPartialMatchAttr = TRUE
  )

This contribution is meaningless, but thought I'd send it anyway! By looking at the most time consuming tests, I set them to run first with testthat which reduces test run time !

I am actually trying to find a way to make messages more colorful but didn't succeed (yet)

My goal is to end up with a message that looks like this
image
Currently, it looks like this

image

@wlandau
Copy link
Member

wlandau commented Nov 21, 2024

Thanks for pointing out those partial matches, I have fixed them in ab30e7b.

I am less sure about parallel tests because targets already launches external processes and CRAN has a strict limit of 2 total.

@olivroy
Copy link
Author

olivroy commented Nov 21, 2024

Great! I will close in this case. I read that it should be handled already r-lib/testthat#1114 (comment), but can't confirm it

@olivroy olivroy closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants