Skip to content

Commit

Permalink
Fix #1172
Browse files Browse the repository at this point in the history
  • Loading branch information
wlandau-lilly committed Nov 13, 2023
1 parent 5604ac8 commit 21f5730
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 14 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Description: Pipeline tools coordinate the pieces of computationally
The methodology in this package
borrows from GNU 'Make' (2015, ISBN:978-9881443519)
and 'drake' (2018, <doi:10.21105/joss.00550>).
Version: 1.3.2.9002
Version: 1.3.2.9003
License: MIT + file LICENSE
URL: https://docs.ropensci.org/targets/, https://github.com/ropensci/targets
BugReports: https://github.com/ropensci/targets/issues
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# targets 1.3.2.9002 (development)
# targets 1.3.2.9003 (development)

## Invalidating changes

Expand Down
12 changes: 3 additions & 9 deletions R/class_gcp.R
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,9 @@ store_has_correct_hash.tar_gcp <- function(store) {
}

store_gcp_hash <- function(store) {
path <- store$file$path
head <- gcp_gcs_head(
key = store_gcp_key(path),
bucket = store_gcp_bucket(path),
version = store_gcp_version(path),
verbose = store$resources$gcp$verbose %|||% FALSE,
max_tries = store$resources$gcp$max_tries %|||% 5L
)
if_any(is.null(head), NULL, digest_chr64(head$md5))
tar_runtime$inventories$gcp <- tar_runtime$inventories$gcp %|||%
inventory_gcp_init()
tar_runtime$inventories$gcp$get_cache(store = store)
}
# nocov end

Expand Down
2 changes: 1 addition & 1 deletion R/utils_gcp.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ gcp_gcs_list_md5s <- function(
verbose = TRUE,
max_tries = NULL
) {
verbose <- verbose %|||% FALSE
verbose <- verbose %|||% TRUE
old_try_attempts <- getOption("googleAuthR.tryAttempts")
on.exit(options(googleAuthR.tryAttempts = old_try_attempts), add = TRUE)
if_any(
Expand Down
4 changes: 2 additions & 2 deletions tests/gcp/test-class_gcp_qs.R
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ tar_test("gcp_qs format versioning", {
})
expr <- tar_tidy_eval(expr, environment(), TRUE)
eval(as.call(list(`tar_script`, expr, ask = FALSE)))
expect_equal(targets::tar_outdated(callr_function = NULL), character(0))
expect_equal(targets::tar_outdated(callr_function = NULL), "x")
tar_make(callr_function = NULL)
expect_equal(tar_progress(x)$progress, "skipped")
expect_equal(tar_progress(x)$progress, "built")
})

0 comments on commit 21f5730

Please sign in to comment.