Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shelter part3: update the conditions for closing the popup window and the burger menu #1682

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

anthony-th
Copy link
Contributor

@anthony-th anthony-th commented Aug 6, 2024

Remove the ambiguity

🤔 This is a ...

  • ❓ Other (specify: with this adjustment, disputes about the double meaning of these task items will disappear..)

@anthony-th anthony-th changed the title docs: update popup closing condition Shelter part3: update popup closing condition Aug 6, 2024
@lyutails lyutails requested a review from WiiJoy August 6, 2024 14:41
@lyutails
Copy link
Collaborator

lyutails commented Aug 6, 2024

one more variant :)

  • попап закрывается при нажатии на область вокруг попапа (overlay), при этом при нажатии на сам попап ничего не происходит +1
  • попап закрывается при нажатии на крестик в углу модального окна, при этом при нажатии на сам попап ничего не происходит +1

but this way we don't follow DRY then...

  • попап можно закрыть двумя способами - нажатием на область вокруг (overlay) или на крестик в углу модального окна, при этом при нажатии на сам попап ничего не происходит +2

though your variant is fine too :)

@anthony-th anthony-th changed the title Shelter part3: update popup closing condition Shelter part3: гpdate the conditions for closing the popup window and the burger menu Aug 6, 2024
@anthony-th anthony-th changed the title Shelter part3: гpdate the conditions for closing the popup window and the burger menu Shelter part3: update the conditions for closing the popup window and the burger menu Aug 6, 2024
@WiiJoy WiiJoy merged commit d4da815 into rolling-scopes-school:master Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants