Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [week-7] fix 'not recommended' examples #1332

Closed
wants to merge 4 commits into from
Closed

docs: [week-7] fix 'not recommended' examples #1332

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48be498
docs: fix 'not recommended' examples
shiyananan Nov 15, 2023
f8f0939
docs: fix 'not recommended' examples from part 3
shiyananan Nov 15, 2023
f47beec
Merge branch 'rolling-scopes-school:master' into master
shiyananan Nov 29, 2023
c053b62
Merge branch 'rolling-scopes-school:master' into master
shiyananan Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions stage1/modules/clean-code/materials/html-and-css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@

```html
<!-- Not recommended -->
<a href="/">Home</a>
<A HREF="/">Home</a>

<!-- Recommended -->
<img src="google.png" alt="Google" />
```

```css
/* Not recommended */
color: #e5e5e5;
color: #E5E5E5;

/* Recommended */
color: #e5e5e5;
Expand All @@ -57,7 +57,7 @@ color: #e5e5e5;

```html
<!-- Not recommended -->
<a class="main-button main-button-secondary">Sign in</a>
<a class='main-button main-button-secondary'>Sign in</a>

<!-- Recommended -->
<a class="main-button main-button-secondary">Sign in</a>
Expand Down Expand Up @@ -366,7 +366,7 @@ div.error {
```css
/* Not recommended */
h3 {
font-weight: bold;
font-weight:bold;
}

/* Recommended */
Expand All @@ -384,8 +384,8 @@ h3 {
```css
/* Not recommended */
.test {
display: block;
height: 100px;
display: block,
height: 100px,
}

/* Recommended */
Expand All @@ -403,8 +403,7 @@ h3 {

```css
/* Not recommended */
a:focus,
a:active {
a:focus, a:active {
position: relative;
top: 1px;
}
Expand Down