Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Add penalties for not following PR requirements #1330

Merged
merged 7 commits into from
Dec 10, 2023
Merged

React: Add penalties for not following PR requirements #1330

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1b4d5a
feat: subtract points if pr does not follow guideline
lyutails Nov 14, 2023
7391b39
feat: subtract points if pr does not follow guideline module 01
lyutails Nov 14, 2023
827eb05
feat: subtract points if pr does not follow guideline module 02
lyutails Nov 14, 2023
2f19971
feat: subtract points if pr does not follow guideline module 04
lyutails Nov 14, 2023
fd33091
feat: subtract points if pr does not follow guideline module 05
lyutails Nov 14, 2023
aa2b12a
fix: reformulated
lyutails Nov 15, 2023
9be9560
feat: change back to how it was previously formulated on first run
lyutails Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions react/modules/module01/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ Run app and check that the functionality is working (cross-check)
- Presence of _code-smells_ (God-object, chunks of duplicate code), commented code sections: **-10 points per each**
- Usage of Redux or other state management libraries: **-100 points**
- Usage of component libraries, e.g. Material UI, Ant Design: **-100 points**
- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points**
kravaring marked this conversation as resolved.
Show resolved Hide resolved

### Repository requirements

Expand Down
1 change: 1 addition & 0 deletions react/modules/module02/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ A student can achieve a maximum of 100 points.
- Usage of Redux or other state management libraries: **-100 points**
- Usage of component libraries, e.g. Material UI, Ant Design: **-100 points**
- Commits after the deadline: **-40 points**
- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points**

### Repository Requirements

Expand Down
1 change: 1 addition & 0 deletions react/modules/module03/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ Run app and check that the functionality is working (cross-check)
- Usage of component libraries, e.g. Material UI, Ant Design: **-100 points**
- Test coverage is less than 80%: **-30 points**
- Commits after the deadline: **-40 points**
- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points**

### Repository requirements

Expand Down
1 change: 1 addition & 0 deletions react/modules/module04/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ Run app and check that the functionality is working (cross-check)
- Usage of component libraries, e.g. Material UI, Ant Design: **-100 points**
- Test coverage is less than 80%: **-30 points**
- Commits after the deadline: **-40 points**
- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points**

### Repository requirements

Expand Down
1 change: 1 addition & 0 deletions react/modules/module05/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ Run app and check that the functionality is working (cross-check)
- Usage of client state on page: **-20 points** per each
- Pages API isn't used: **-50 points**
- Commits after the deadline: **-40 points**
- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points**

### Repository requirements

Expand Down
Loading