Clean code s1e1 #51
Open
Clean code s1e1 #51
+290
−286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor HTML code: - Improved code structure and formatting for better readability and maintainability - Added appropriate alt attributes to image tags for accessibility - Updated class names for consistency and clarity - Fixed missing closing tags and added proper indentation - Replaced uppercase tags with lowercase tags for HTML5 compliance - Corrected attribute values for media and type attributes in link tags - Changed script tag attribute from SRC to src - Moved script tag to the end of the body for optimized page loading Update CSS styles: - Reorganized and optimized CSS styles for better readability and maintainability - Adjusted container width and centered it horizontally - Updated class names for clarity and consistency - Added responsive styles for smaller screen sizes using media queries - Aligned task items and improved spacing and margins - Updated button styles and added hover effects - Improved input field styles and focus state - Added comments for better code documentation
…BEM in CSS, HTML, JS files
…BEM in CSS, HTML, JS files
…BEM in CSS, HTML, JS files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic 1.1 'Indentation' from html-and-css is followed throughout the entire project: tabs are not used, all indentations are made with a space character +2
Basic 1.2 'Lower case writing' from html-and-css is implemented throughout the entire project: all HTML tags, value attributes, selectors and their values are written in lower case +2
Basic 1.3 'Quotes in HTML/CSS document' from html-and-css is followed throughout the entire project: only double quotes are used in HTML and CSS files +2
Basic 2.1 'Formatting' from html-and-css is carried out throughout the entire project: all block, table and list elements are moved to a separate line and indented in accordance with the nesting ladder +2
Basic 2.2 'Document Type' from html-and-css is carried out throughout the project: doctype is present as the first tag in the html document and corresponds to the html5 +2 type
Basic 2.3 'Mnemonic symbols' from html-and-css is followed throughout the entire project: mnemonic symbols are not used in html files +2
Basic 2.4 The 'type' attribute from html-and-css is executed throughout the entire project: CSS styles and JS scripts are included without using this attribute +2
Basic 3.5 'Indentations in blocks' from html-and-css is carried out throughout the entire project: the contents of all blocks are separated by +2 indentations
Basic 3.6 'Space after property names' from html-and-css is enforced throughout the entire project: CSS property values are separated by spaces after the colon +2
Basic 3.7 'Semicolon after properties' from html-and-css is enforced throughout the project: after each CSS rule there is a semicolon +2
Basic 3.8 'Separating selectors and properties' from html-and-css is carried out throughout the entire project: each selector in the group enumeration of a CSS block is separated by a line break +2
Extended 1.1 'Semantics' from html-and-css-extended is followed: all html tags are used in accordance with their purpose. At the same time, the use of div elements is reduced to a minimum, where possible they are replaced with semantic html5 elements +5
Extended 1.2 'Alternative for multimedia' from html-and-css-extended is followed: each multimedia element (in this task img) has an alt attribute with meaningful content corresponding to the content of the elements. At the same time, purely decorative pictures have an empty alt value. +5
Extended 2.1 'BEM' from html-and-css-extended is followed: all classes are named according to BEM notation +5
Rules basic 3.1 - 3.4 have been corrected by rule extended 2.1, which is allowed according to the requirements of the task
Basic 3.1 'Uniform naming style for selectors (classes / id)' from html-and-css is followed throughout the entire project: all selectors are named in the same style, either in accordance with BEM, or all words are in lowercase and separated by a hyphen +2
Basic 3.2 'Meaningful names of identifiers and classes' from html-and-css is followed throughout the entire project: all class and identifier names have either meaningful names according to their functional meaning (!but NOT APPEARANCE!), or template name (also corresponding to the purpose of the element) +2
Basic 3.3 'Conciseness of identifier and class names' from html-and-css is followed throughout the entire project: all id and class names are clear, long enough to understand their purpose, and at the same time concise +2
Basic 3.4 'Tag selectors' from html-and-css is followed throughout the entire project: tag selectors are not used (except for intentionally resetting default styles) +2