Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new PlatformDispatcher onError method if available #109

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 2, 2023

Description of the change

This PR implements the new recommended method to catch exceptions that don't occur within Flutter's callbacks according to https://docs.flutter.dev/testing/errors.

This swizzles the PlatformDispatcher.onError callback with our own callback which also calls the original one.

Previously, we were using a custom Zone to catch this class of exceptions but it was deprecated in Flutter 3.3.

We aim to preserve compatibility with Flutter < 3.3.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Aug 2, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #129017: Flutter SDK isn't catching async errors.

@matux matux marked this pull request as ready for review August 2, 2023 14:13
@matux matux merged commit 6198568 into main Aug 2, 2023
@matux matux deleted the onerror branch August 2, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting from Flutter 3.3 catching errors via PlatformDispatcher.onError is now the recommended approach.
2 participants