Ensure WidgetFlutterBinding.ensureInitialized() is run on the same zone

rollbar · May 31, 2023 · dbb1df5 · dbb1df5
1 parent 90eff1f
commit dbb1df5
Showing 1 changed file with 23 additions and 14 deletions.
diff --git a/rollbar_flutter/lib/src/rollbar.dart b/rollbar_flutter/lib/src/rollbar.dart
@@ -1,8 +1,9 @@
 import 'dart:async';
 
-import 'package:meta/meta.dart';
+import 'package:flutter/foundation.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter/widgets.dart';
+import 'package:meta/meta.dart';
 
 import 'package:rollbar_dart/rollbar.dart';
 
@@ -30,29 +31,37 @@ class RollbarFlutter {
     Config config,
     RollbarClosure appRunner,
   ) async {
-    WidgetsFlutterBinding.ensureInitialized();
+    if (!config.handleUncaughtErrors) {
+      WidgetsFlutterBinding.ensureInitialized();
 
-    await Rollbar.run(config.copyWith(
-      framework: 'flutter',
-      persistencePath: await _platform.persistencePath,
-      transformer: (_) => PlatformTransformer(),
-    ));
+      await _run(config, appRunner, null);
 
-    if (!config.handleUncaughtErrors) {
-      await _platform.initialize(config: config);
-      await appRunner();
       return;
     }
 
     await runZonedGuarded(() async {
       WidgetsFlutterBinding.ensureInitialized();
 
-      FlutterError.onError = RollbarFlutterError.onError;
-
-      await _platform.initialize(config: config);
-      await appRunner();
+      await _run(config, appRunner, RollbarFlutterError.onError);
     }, (exception, stackTrace) {
       Rollbar.error(exception, stackTrace);
     });
   }
+
+  static Future<void> _run(
+    Config config,
+    RollbarClosure appRunner,
+    FlutterExceptionHandler? onError,
+  ) async {
+    await Rollbar.run(config.copyWith(
+      framework: 'flutter',
+      persistencePath: await _platform.persistencePath,
+      transformer: (_) => PlatformTransformer(),
+    ));
+
+    FlutterError.onError ??= onError;
+
+    await _platform.initialize(config: config);
+    await appRunner();
+  }
 }