Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #398 FastAPI integration fails if docs are disabled. #459

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This fixes a bug with the FastAPI integration. Our previous implementation assumed the app would have docs enabled. This resolves that and also allows fixes the issue for two other URLs.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell requested a review from alif September 20, 2024 19:59
@danielmorell danielmorell added this to the 1.1.0 milestone Sep 20, 2024
@danielmorell danielmorell merged commit 94cbfb8 into master Sep 20, 2024
75 checks passed
@danielmorell danielmorell deleted the fixed/issue-398-fastapi-fails-if-docs-disabled branch September 20, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants