Fixed shortener key matching above final '*' level.

rollbar · May 17, 2024 · 7ece3cb · 7ece3cb
1 parent 96bb8eb
commit 7ece3cb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/rollbar/lib/__init__.py b/rollbar/lib/__init__.py
@@ -56,18 +56,16 @@ def key_depth(key, canonicals) -> int:
 
 
 def key_match(key, canonical):
-    i = 0
+    if len(key) < len(canonical):
+        return False
+
     for k, c in zip(key, canonical):
-        i += 1
         if '*' == c:
             continue
         if c == k:
             continue
         return False
 
-    if i < len(canonical) - 1:
-        return False
-
     return True
 
 

diff --git a/rollbar/test/test_lib.py b/rollbar/test/test_lib.py
@@ -30,6 +30,12 @@ def test_key_match_wildcard_end(self):
 
         self.assertTrue(key_match(key, canonical))
 
+    def test_key_match_too_short(self):
+        canonical = ['body', 'trace', 'frames', '*', 'locals', '*']
+        key = ['body', 'trace', 'frames', 5, 'locals']
+
+        self.assertFalse(key_match(key, canonical))
+
     def test_key_depth(self):
         canonicals = [['body', 'trace', 'frames', '*', 'locals', '*']]
         key = ['body', 'trace', 'frames', 5, 'locals', 'foo']