Add a $paths field for folders
#936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows a folder's contents to be the sum of multiple folders' contents Ideal for composing forms of a project depending on rojo's project files e.g. multi-place games, libraries with tiered features for releases, etc
|
Howdy! I'm going to wait to give this a review until syncback is merged since rather selfishly I don't want to handle the merge conflicts on a PR that's already massive. I will get back to you though, promise. |
Dekkonot
added
type: enhancement
|
Agreed tbh, makes sense for the large structural change to go first. This PR should have to work with syncback rather than the other way around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is an acceptable feature but I wanted to see if it was possible 🙂
Allows a roblox folder's contents to be the sum of multiple flesystem folders' contents. Enhances the ability for rojo to change a project's form based on project files. E.G. multi-place games, libraries with tiered features for releases, a
tests.project.jsonfileThis feature may conflict with syncback since it introduces an ambiguity where new contents of a roblox folder should be stored. If possible, I think it would be acceptable to use the first path in the list of paths as a "dominant" one, treating it like the base folder on the filesystem.
Notes: