Implement rojo open
#622
Closed
Implement rojo open
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezuo
reviewed
Aug 13, 2022
src/cli/open.rs
Outdated
|
|
||
| let server = LiveServer::new(Arc::new(session)); | ||
|
|
||
| let _ = show_start_message(ip, port, global.color.into()); |
There was a problem hiding this comment.
Suggested change
| let _ = show_start_message(ip, port, global.color.into()); | |
| show_start_message(ip, port, global.color.into()); |
I think the Result this function returns might need to be handled as well.
There was a problem hiding this comment.
I see now that the serve command does this. I guess it was to ignore the result. @LPGhatguy should the result be ignored here?
Boegie19
reviewed
Aug 13, 2022
boatbomber
added
type: enhancement
|
Superseded by #896. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305.
From #305:
Maybe the plugin could expose a function in _G to connect & the server would inject a new plugin that calls that function with the required address and port?