This repository has been archived by the owner on Jul 22, 2023. It is now read-only.
Add Instance:IsA() #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
reviewed
Jul 19, 2021
src/roblox_api/instance.rs
Outdated
Comment on lines
250
to
258
| let mut descriptor = database | ||
| .classes | ||
| .get(instance.class.as_str()) | ||
| .ok_or_else(|| { | ||
| rlua::Error::external(format!( | ||
| "Unable to obtain class {} from reflection database", | ||
| &instance.class | ||
| )) | ||
| })?; |
There was a problem hiding this comment.
Can we restructure our loop so that this line only needs to happen once? If we start with
let mut class = Some(&descriptor.class);and loop from there, we should be able to only have one block that calls classes.get
There was a problem hiding this comment.
Let me know if that's similar to what you had in mind 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.