Upgrade criterion to 0.5.1, reorganize benchmarks #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialization would not be accurate before, because the serialized size will not necessarily the same as the input file
kennethloeffler
added a commit
to kennethloeffler/rbx-dom
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates criterion to the latest version (silencing an annoying warning), and completely restructures rbx_binary's benchmarks so that they're way easier to add.
It also replaces the 10,000 part benchmark with a 1,000 part benchmark, because the 10,000 part benchmark was rather slow to run, making it too hard to take enough samples.