-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SecurityCapabilities in rbx_types #358
Implement SecurityCapabilities in rbx_types #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put this in the changelog, but this is overall a good barebones implementation for it.
We should also provide a method to get the inner value
though, since we'll need it for serializing. I'll leave the exact name up to you.
We won't need any accessor for parsing - for reading, rbx_xml can use This also has me thinking... maybe |
Decided to axe the Display impl - this accessor should be fine to continue support for even if we switch to bitflags
Ok, I just removed the Display impl and added a |
Should EDIT: meh, it has to if we want to be a variant. This blows! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not thrilled with implementing Serialize
/Deserialize
but I suppose we have to for Variant
. With that in mind, this looks fine to me.
Cool, I'll put up PRs for reflection, rbx_binary, and rbx_xml later today |
This PR implements
SecurityCapabilities
in rbx_types. Its functionality is very limited right now because we have almost no idea what this datatype does or how to interact with it!I want rojo-rbx/rbx-test-files#23 merged before adding functionality for
SecurityCapabilities
to any other of the crates. dekko pls review it thoroughly and make sure I got it right