'Custom LED' Split LED Display Fix Patch #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmhoneycutt343
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch I did to fix the fact that 'Custom LED Scales' (The 'fret inlay' type / 7 color LED scale) would clobber LEDs for 'special splits' like the cc fader / strum; as well as clobber cc fader LEDs when not in split mode. It should be noted that this patch does not add support for the 'Custom LED Scales' to display during the 'Split Point' Choosing Mode.
Edit: Forgot to mention this patch also adds a column of yellow LEDS to the right most column of the right split if both sides are special scale - I can remove this is it's deemed to be a feature 'add'