Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade http_parser dep to 4.0.2 #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Downgrade http_parser dep to 4.0.2 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
046cc62
Downgrade http_parser dep to 4.0.2
Nov 14, 2024
63b1d3d
Update DCM
Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,7 @@ linter:
rules:
public_member_api_docs: false

analyzer:
plugins:
- dart_code_metrics

dart_code_metrics:
anti-patterns:
- long-method
metrics:
cyclomatic-complexity: 20
maximum-nesting-level: 5
Expand All @@ -24,7 +18,6 @@ dart_code_metrics:
- no-equal-arguments:
severity: warning
- avoid-unused-parameters
- binary-expression-operand-order
- no-object-declaration
- prefer-trailing-comma:
exclude:
Expand Down
1 change: 0 additions & 1 deletion lib/src/default_retry_evaluator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ class DefaultRetryEvaluator {

/// Returns true only if the response hasn't been cancelled
/// or got a bad status code.
// ignore: avoid-unused-parameters
FutureOr<bool> evaluate(DioException error, int attempt) {
bool shouldRetry;
if (error.type == DioExceptionType.badResponse) {
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ environment:

dependencies:
dio: ^5.7.0
http_parser: ^4.1.0
http_parser: ^4.0.2
path: ^1.9.0

dev_dependencies:
Expand Down
2 changes: 2 additions & 0 deletions test/disable_retry_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
@TestOn('vm')
library;

import 'package:dio/dio.dart';
import 'package:dio_smart_retry/dio_smart_retry.dart';
import 'package:test/test.dart';
Expand Down
2 changes: 2 additions & 0 deletions test/multipart_retry_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
@TestOn('vm')
library;

import 'package:dio/dio.dart';
import 'package:dio_smart_retry/dio_smart_retry.dart';
import 'package:test/test.dart';
Expand Down
2 changes: 2 additions & 0 deletions test/override_retryable_statuses_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
@TestOn('vm')
library;

import 'package:dio/dio.dart';
import 'package:dio_smart_retry/dio_smart_retry.dart';
import 'package:test/test.dart';
Expand Down
2 changes: 2 additions & 0 deletions test/test_issue_2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// https://github.com/rodion-m/dio_smart_retry/issues/2
@TestOn('vm')
library;


import 'package:dio/dio.dart';
import 'package:dio_smart_retry/dio_smart_retry.dart';
Expand Down