Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and recommend appropriate npm and node versions #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:7.10.0
FROM node:8.9.4
RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app
COPY package.json /usr/src/app/package.json
Expand Down
6 changes: 3 additions & 3 deletions docs/GETSTARTED.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ We will be focused on React and Redux based applications in this starter-guide.
Keep in mind that Roc is **not** tied to React and Redux extensions. Creating your own extension is also an option.

## Install Roc
Make sure you have [Node.js](https://nodejs.org) 4.x or higher and [npm](https://www.npmjs.com/) 3.x or higher on your system.
Make sure you have [Node.js](https://nodejs.org) 8.x or higher and [npm](https://www.npmjs.com/) 5.x or higher on your system.

__Currently with official support for Mac, Linux and Windows.__

Expand Down Expand Up @@ -169,7 +169,7 @@ Stability and productivity is the most important. However a dependency-update __
Yes, this works great. Here is an example `Dockerfile`

```dockerfile
FROM node:7.10.0
FROM node:8.9.4
RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app
COPY package.json /usr/src/app/package.json
Expand All @@ -181,7 +181,7 @@ EXPOSE 3000
```

## I am a bit stuck, where can I find more information?
We have written a [comprehensive user-guide](https://github.com/rocjs/roc-package-web-app-react/blob/master/GUIDE.md). Check it out!
We have written a [comprehensive user-guide](https://github.com/rocjs/extensions/blob/master/packages/roc-package-web-app-react/GUIDE.md). Check it out!

Roc with `roc-package-web-app-react` installs and manages many libraries for you so that you can focus on your application. Below is a link outlining the most important libraries you should be familiar with when using `roc-package-web-app-react`. They are provided to you automatically, and Roc does not modify their API.

Expand Down
2 changes: 1 addition & 1 deletion docs/QUICKSTART-1.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#### Install
Make sure you have node 4.x+ and npm 3.x+ on your system.
Make sure you have node 8.x+ and npm 5.x+ on your system.
```
npm install -g roc@next
```
Expand Down