roc_pipeline benchmark: fix a task completer race #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In peakload benchmarks it is possible for the TaskThread object to be removed along with the pipeline_task_completed() callback before all tasks are completed. This results in a SIGABRT with "pure virtual method called" message. To fix this move pipeline_task_completed() to TestPipeline class that has a longer lifespan. Fixes: roc-streaming#537
github-actions
bot
added
the
contribution
gavv
force-pushed
the
task_completer_thread_race_fix
branch
from
063b1bc to
ee3f557
Compare
|
Thanks a lot! When testing this, I found that this benchmarks had a few regressions after recent rework of factory interfaces. (Probably you've noticed too). I've pushed a fix: d6bf124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In peakload benchmarks it is possible for the TaskThread object to be removed along with the pipeline_task_completed() callback before all tasks are completed. This results in a SIGABRT with "pure virtual method called" message.
To fix this move pipeline_task_completed() to TestPipeline class that has a longer lifespan.
Fixes: #537