Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RingQueue::resize() #774

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

AvvALlV
Copy link

@AvvALlV AvvALlV commented Aug 4, 2024

Implements #770

@github-actions github-actions bot added the contribution A pull-request by someone else except maintainers label Aug 4, 2024
@gavv gavv added the ready for review Pull request can be reviewed label Aug 7, 2024
@gavv gavv added this to the next milestone Nov 26, 2024
@gavv gavv merged commit ecd0d97 into roc-streaming:develop Nov 26, 2024
2 checks passed
@gavv
Copy link
Member

gavv commented Nov 26, 2024

Hi, thanks for the patch and sorry for delay.

Here is a follow-up commit: d90cf31

I've changed behavior a bit: resize() now changes capacity(), not size(). Adding empty elements to the end of the queue seems to have little sense, and what we really need is just adding or removing extra memory. I also expanded the test a bit to cover this.

@github-actions github-actions bot removed the ready for review Pull request can be reviewed label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution A pull-request by someone else except maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants