Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement safe backtrace print and exit upon SIGQUIT #736

Closed
wants to merge 1 commit into from
Closed

implement safe backtrace print and exit upon SIGQUIT #736

wants to merge 1 commit into from

Conversation

MicJagger
Copy link

@MicJagger MicJagger commented Jun 22, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

@gavv
Copy link
Member

gavv commented Jun 22, 2024

Hi,

This patch is odd. signal_string() returns a string name of a signal, why on earth are you calling exit from it? Also you're not installing signal handler. _exit() doesn't take a signal as an argument (see man page). And all other signals are handled via die_gracefully(), not by calling exit.

@MicJagger MicJagger closed this Jun 22, 2024
@gavv gavv added dismissed We decided not to fix the issue for some reason contribution A pull-request by someone else except maintainers labels Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contribution A pull-request by someone else except maintainers dismissed We decided not to fix the issue for some reason
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicJagger @gavv