Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement warmup phase #686

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Implement warmup phase #686

merged 1 commit into from
Feb 2, 2024

Conversation

zann136
Copy link
Contributor

@zann136 zann136 commented Jan 31, 2024 •
edited
Loading

Implemented warmup phase in watchdog for #657
Added tests for watchdog and receiver pipeline

@github-actions github-actions bot added the work in progress Pull request is still in progress and changing label Jan 31, 2024
@github-actions GitHub Actions
Copy link

🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

@zann136 zann136 marked this pull request as ready for review January 31, 2024 16:56
@github-actions github-actions bot added ready for review Pull request can be reviewed and removed work in progress Pull request is still in progress and changing labels Jan 31, 2024
@zann136 zann136 changed the title Implement warmup Implement warmup phase Jan 31, 2024
@gavv gavv added the contribution A pull-request by someone else except maintainers label Jan 31, 2024
@gavv gavv added this to the next milestone Feb 2, 2024
@gavv gavv force-pushed the 657_implement_warmup branch from 4c64b57 to dffb139 Compare February 2, 2024 08:32
@gavv gavv merged commit 94d3b14 into roc-streaming:develop Feb 2, 2024
@github-actions github-actions bot removed the ready for review Pull request can be reviewed label Feb 2, 2024
@gavv
Copy link
Member

gavv commented Feb 2, 2024

Thank you, LGTM!

I've pushed two follow-up commits:

  • 7130397 - this one is not related to pr itself, just some cleanup that I wanted to do in watchdog for a long time
  • b46afb5 - this one improves pipeline tests

See commit messages for detailed description of what changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contribution A pull-request by someone else except maintainers
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zann136 @gavv