Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO_COLOR and FORCE_COLOR env vars support #666

Merged
merged 1 commit into from
Dec 28, 2023
Merged

NO_COLOR and FORCE_COLOR env vars support #666

merged 1 commit into from
Dec 28, 2023

Conversation

nolan-veed
Copy link
Contributor

@nolan-veed nolan-veed commented Dec 27, 2023 •
edited
Loading

Why

For #564

What

  • Created functions to check for NO_COLOR and FORCE_COLOR.
  • Created function to check if term supports color.
  • Used those methods in detect_color_support()
    • Prefer NO_COLOR if both vars are available.
  • Updated man sources.
  • Generated man pages as well.

Testing

  • Tested NO_COLOR using ubuntu terminal.
    image
  • Tested FORCE_COLOR by using ssh to localhost.
    image

@github-actions github-actions bot added the work in progress Pull request is still in progress and changing label Dec 27, 2023
@github-actions GitHub Actions
Copy link

🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

@nolan-veed
Copy link
Contributor Author

Is there a better way to generate man pages?

nolan@nolan-veed:~/nolan-veed/roc-toolkit$ scons -Q --enable-werror --enable-doxygen --enable-sphinx docs
   SPHINX   docs/html/docs
   SPHINX   docs/man


Extension error:



Could not import extension sphinxemoji.sphinxemoji (exception: No module named 'sphinxemoji')
Extension error:

Could not import extension sphinxemoji.sphinxemoji (exception: No module named 'sphinxemoji')
scons: *** [build/docs/sphinx.html/commit] Error 2
scons: *** [build/docs/sphinx.man/commit] Error 2

@nolan-veed
Copy link
Contributor Author

Is there a better way to generate man pages?

Never mind fixed it.

@nolan-veed nolan-veed marked this pull request as ready for review December 27, 2023 22:31
@github-actions github-actions bot added ready for review Pull request can be reviewed and removed work in progress Pull request is still in progress and changing labels Dec 27, 2023
@gavv gavv added the contribution A pull-request by someone else except maintainers label Dec 28, 2023
@gavv gavv added this to the next milestone Dec 28, 2023
@gavv gavv force-pushed the 564-NO_COLOR-FORCE_COLOR-env-vars branch from 247a14f to f3f5ffd Compare December 28, 2023 08:55
@gavv gavv merged commit 6c6057b into roc-streaming:develop Dec 28, 2023
17 checks passed
@github-actions github-actions bot removed the ready for review Pull request can be reviewed label Dec 28, 2023
@gavv
Copy link
Member

gavv commented Dec 28, 2023

Thanks! Works great. Small follow-up commit: a09cc57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contribution A pull-request by someone else except maintainers
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nolan-veed @gavv