Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 24.04 builds #665

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Ubuntu 24.04 builds #665

merged 1 commit into from
Dec 28, 2023

Conversation

nolan-veed
Copy link
Contributor

Why

For #634

This adds the ci builds.

What

  • Wrote script for Ubuntu 24.04.
    • Supported the 2 latest g++ and clang versions for building.
  • Updated build.yml.

Testing

Should run on CI.

@github-actions GitHub Actions
Copy link

🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

@gavv
Copy link
Member

gavv commented Dec 28, 2023

As mentioned in roc-streaming/dockerfiles#16, please also update https://roc-streaming.org/toolkit/docs/development/continuous_integration.html

@gavv gavv added needs revision Pull request should be revised by its author contribution A pull-request by someone else except maintainers labels Dec 28, 2023
@gavv
Copy link
Member

gavv commented Dec 28, 2023

We forgot to add 24.04 to CI, done: roc-streaming/dockerfiles@aecc5ad

(most images build all tags automatically, however for ubuntu each tag should be added manually, because we need to split ubuntu images into multiple CI jobs to avoid exceeding github limits for maximum job times)

@gavv gavv added ready for review Pull request can be reviewed and removed needs revision Pull request should be revised by its author labels Dec 28, 2023
@nolan-veed
Copy link
Contributor Author

nolan-veed commented Dec 28, 2023 •
edited
Loading

We forgot to add 24.04 to CI...

Don't think I have perms to run the jobs again.

Oh wait... some other builds have failed as well. Something is unstable in develop.

@gavv
Copy link
Member

gavv commented Dec 28, 2023

There are two other failures:

  1. Formatting. The problem appeared after we switched env-ubuntu:latest to 24.04. It uses more recent clang-format that disagrees with previous versions about formatting of one line. Unfortunately clang-format is not yet fully stabilized and it happens from time to time. For now, I just excluded the problematic file from auto-formatting: 9b159e8

  2. Pulseaudio build. Will take a look.

@gavv gavv added this to the next milestone Dec 28, 2023
@gavv gavv force-pushed the 634-ubuntu24.04-support branch from 7534e72 to b1c784f Compare December 28, 2023 20:36
@gavv gavv merged commit 20048b3 into roc-streaming:develop Dec 28, 2023
30 of 31 checks passed
@gavv
Copy link
Member

gavv commented Dec 28, 2023

LGTM!

@github-actions github-actions bot removed the ready for review Pull request can be reviewed label Dec 28, 2023
@gavv
Copy link
Member

gavv commented Dec 28, 2023

I've fixed pulseaudio build: e252b2b

It was caused by update to clang 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavv gavv gavv left review comments

Assignees
No one assigned
Labels
contribution A pull-request by someone else except maintainers
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nolan-veed @gavv