Rename Pool #646
Merged
Rename Pool #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats. |
gavv
added
ready for review
|
Thanks! I think we should rename PoolFlags/PoolFlag_EnableGuards/DefaultPoolFlags too. |
I've fixed that check to support links to issue comment. |
gavv
added
needs revision
Yes. I wasn't sure about that. |
gavv
force-pushed
the
610-rename-Pool
branch
3 times, most recently
from
3ebac69 to
2eb6a88
Compare
gavv
force-pushed
the
610-rename-Pool
branch
from
2eb6a88 to
c5748f6
Compare
|
Thanks! |
github-actions
bot
removed
the
needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
For #610, specifically #610 (comment)
What
Renamed Pool to SlabPool, including files.
Renamed PoolImpl to SlabPoolImpl, including files.
Renamed file using snake_case.
There might be some general references to pool in the documentation - not sure if we want to change that.
Testing
There are tests.