-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print_supported implemented for recv and send tools. #642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for PR! Here are a few comments.
Yep, consolidated should be included. |
3ff1044
to
3197896
Compare
3197896
to
c62062b
Compare
Thanks for update, LGTM! BTW, please don't resolve discussions by yourself, keep them for reviewer, otherwise it's hard to track what is needed to be re-reviewed. Instead you can add comment or 👍 on discussion to indicate that it was addressed. |
Ah my mistake, understood. I'll stick to using comments/thumbs up instead. I thought the resolve something each of us did individually on our own ends. |
Issue #578
I am uncertain if the consolidated interface enumeration and its corresponding protocol should be a part of the printed list, but otherwise I believe I've done this all correctly.