Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringBuffer and StringBuilder changes #603

Merged
merged 3 commits into from
Oct 9, 2023
Merged

StringBuffer and StringBuilder changes #603

merged 3 commits into from
Oct 9, 2023

Conversation

ForeverASilver
Copy link
Contributor

Made changes according to gh-600

gavv
gavv reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@gavv gavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! A few small comments.

src/internal_modules/roc_core/string_buffer.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_core/string_builder.h Outdated Show resolved Hide resolved
src/internal_modules/roc_core/string_builder.cpp Outdated Show resolved Hide resolved
@gavv gavv added needs revision Pull request should be revised by its author contribution A pull-request by someone else except maintainers labels Oct 9, 2023
@gavv gavv merged commit 2ed3c96 into roc-streaming:develop Oct 9, 2023
31 checks passed
@gavv
Copy link
Member

gavv commented Oct 9, 2023

LGTM!

@gavv gavv removed the needs revision Pull request should be revised by its author label Oct 9, 2023
@ForeverASilver ForeverASilver deleted the stringbuffer branch October 9, 2023 17:31
@gavv gavv added this to the 0.3.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavv gavv gavv left review comments

Assignees
No one assigned
Labels
contribution A pull-request by someone else except maintainers
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ForeverASilver @gavv