gh-547 Make PcmFormat enum instead of struct

Instead of a struct with code + endian, use one enum with
all combinations, to simplify the user code.

.fmtignore

@@ -1,4 +1,4 @@
-src/internal_modules/roc_audio/pcm_funcs.h
+src/internal_modules/roc_audio/pcm_format.cpp
 src/internal_modules/roc_core/target_libatomic_ops/roc_core/atomic_ops.h
 src/tests/roc_audio/test_samples/*.h
 src/tests/roc_rtp/test_packets/*.h

SConstruct

@@ -1012,6 +1012,7 @@ if meta.compiler == 'gcc':
             '-Wno-shadow',
             '-Wno-stringop-overflow',
             '-Wno-system-headers',
+            '-Wno-unused-const-variable',
         ]})
 
     env.Append(CXXFLAGS=[
@@ -1061,6 +1062,7 @@ if meta.compiler == 'clang':
             '-Wno-psabi',
             '-Wno-shadow',
             '-Wno-system-headers',
+            '-Wno-unused-const-variable',
         ]})
 
     env.Append(CXXFLAGS=[

src/internal_modules/roc_audio/pcm_decoder.cpp

@@ -13,13 +13,13 @@ namespace roc {
 namespace audio {
 
 IFrameDecoder* PcmDecoder::construct(core::IArena& arena,
-                                     const PcmFormat& pcm_format,
+                                     PcmFormat pcm_format,
                                      const SampleSpec& sample_spec) {
     return new (arena) PcmDecoder(pcm_format, sample_spec);
 }
 
-PcmDecoder::PcmDecoder(const PcmFormat& pcm_format, const SampleSpec& sample_spec)
-    : pcm_mapper_(pcm_format, SampleFormat)
+PcmDecoder::PcmDecoder(PcmFormat pcm_format, const SampleSpec& sample_spec)
+    : pcm_mapper_(pcm_format, SampleFmt)
     , n_chans_(sample_spec.num_channels())
     , stream_pos_(0)
     , stream_avail_(0)

src/internal_modules/roc_audio/pcm_decoder.h

@@ -24,12 +24,11 @@ namespace audio {
 class PcmDecoder : public IFrameDecoder, public core::NonCopyable<> {
 public:
     //! Construction function.
-    static IFrameDecoder* construct(core::IArena& arena,
-                                    const PcmFormat& pcm_format,
-                                    const SampleSpec& sample_spec);
+    static IFrameDecoder*
+    construct(core::IArena& arena, PcmFormat pcm_format, const SampleSpec& sample_spec);
 
     //! Initialize.
-    PcmDecoder(const PcmFormat& pcm_format, const SampleSpec& sample_spec);
+    PcmDecoder(PcmFormat pcm_format, const SampleSpec& sample_spec);
 
     //! Get current stream position.
     virtual packet::stream_timestamp_t position() const;

src/internal_modules/roc_audio/pcm_encoder.cpp

@@ -13,13 +13,13 @@ namespace roc {
 namespace audio {
 
 IFrameEncoder* PcmEncoder::construct(core::IArena& arena,
-                                     const PcmFormat& pcm_format,
+                                     PcmFormat pcm_format,
                                      const SampleSpec& sample_spec) {
     return new (arena) PcmEncoder(pcm_format, sample_spec);
 }
 
-PcmEncoder::PcmEncoder(const PcmFormat& pcm_format, const SampleSpec& sample_spec)
-    : pcm_mapper_(SampleFormat, pcm_format)
+PcmEncoder::PcmEncoder(PcmFormat pcm_format, const SampleSpec& sample_spec)
+    : pcm_mapper_(SampleFmt, pcm_format)
     , n_chans_(sample_spec.num_channels())
     , frame_data_(NULL)
     , frame_byte_size_(0)

src/internal_modules/roc_audio/pcm_encoder.h

@@ -24,12 +24,11 @@ namespace audio {
 class PcmEncoder : public IFrameEncoder, public core::NonCopyable<> {
 public:
     //! Construction function.
-    static IFrameEncoder* construct(core::IArena& arena,
-                                    const PcmFormat& pcm_format,
-                                    const SampleSpec& sample_spec);
+    static IFrameEncoder*
+    construct(core::IArena& arena, PcmFormat pcm_format, const SampleSpec& sample_spec);
 
     //! Initialize.
-    PcmEncoder(const PcmFormat& pcm_format, const SampleSpec& sample_spec);
+    PcmEncoder(PcmFormat pcm_format, const SampleSpec& sample_spec);
 
     //! Get encoded frame size in bytes for given number of samples per channel.
     virtual size_t encoded_byte_count(size_t num_samples) const;