-
-
Notifications
You must be signed in to change notification settings - Fork 216
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gh-599 Seqlock implementation extract
- Loading branch information
1 parent
9b159e8
commit 49137bc
Showing
3 changed files
with
200 additions
and
96 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
/* | ||
* Copyright (c) 2020 Roc Streaming authors | ||
* | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
*/ | ||
|
||
#include "roc_core/seqlock_impl.h" | ||
#include "roc_core/atomic_ops.h" | ||
#include "roc_core/cpu_instructions.h" | ||
|
||
namespace { | ||
// We use hand-rolled loop instead of memcpy() or default (trivial) copy constructor | ||
// to be sure that the copying will be covered by our memory fences. On some | ||
// platforms, memcpy() and copy constructor may be implemented using streaming | ||
// instructions which may ignore memory fences. | ||
void volatile_copy(volatile void* dst, const volatile void* src, size_t val_size) { | ||
volatile char* dst_ptr = reinterpret_cast<volatile char*>(dst); | ||
const volatile char* src_ptr = reinterpret_cast<const volatile char*>(src); | ||
|
||
for (size_t n = 0; n < val_size; n++) { | ||
dst_ptr[n] = src_ptr[n]; | ||
} | ||
} | ||
|
||
} // namespace | ||
|
||
namespace roc { | ||
namespace core { | ||
|
||
SeqlockImpl::SeqlockImpl() | ||
: ver_(0) { | ||
} | ||
|
||
seqlock_version_t SeqlockImpl::version() const { | ||
return AtomicOps::load_seq_cst(ver_); | ||
} | ||
|
||
bool SeqlockImpl::try_store(seqlock_version_t& ver, | ||
void* current_value, | ||
size_t value_size, | ||
const void* new_value) { | ||
seqlock_version_t ver0 = AtomicOps::load_relaxed(ver_); | ||
if (ver0 & 1) { | ||
return false; | ||
} | ||
|
||
if (!AtomicOps::compare_exchange_relaxed(ver_, ver0, ver0 + 1)) { | ||
return false; | ||
} | ||
AtomicOps::fence_release(); | ||
|
||
volatile_copy(current_value, new_value, value_size); | ||
AtomicOps::fence_seq_cst(); | ||
|
||
ver = ver0 + 2; | ||
AtomicOps::store_relaxed(ver_, ver); | ||
|
||
return true; | ||
} | ||
|
||
void SeqlockImpl::exclusive_store(seqlock_version_t& ver, | ||
void* current_value, | ||
size_t value_size, | ||
const void* new_value) { | ||
const seqlock_version_t ver0 = AtomicOps::load_relaxed(ver_); | ||
AtomicOps::store_relaxed(ver_, ver0 + 1); | ||
AtomicOps::fence_release(); | ||
|
||
volatile_copy(current_value, new_value, value_size); | ||
AtomicOps::fence_seq_cst(); | ||
|
||
ver = ver0 + 2; | ||
AtomicOps::store_relaxed(ver_, ver); | ||
} | ||
|
||
// If the concurrent store is running and is not sleeping, retrying 3 times | ||
// should be enough to succeed. This may fail if the concurrent store was | ||
// preempted in the middle, of if there are multiple concurrent stores. | ||
bool SeqlockImpl::try_load_repeat(seqlock_version_t& ver, | ||
const void* current_value, | ||
size_t value_size, | ||
void* return_value) const { | ||
if (try_load_(ver, current_value, value_size, return_value)) { | ||
return true; | ||
} | ||
if (try_load_(ver, current_value, value_size, return_value)) { | ||
return true; | ||
} | ||
if (try_load_(ver, current_value, value_size, return_value)) { | ||
return true; | ||
} | ||
return false; | ||
} | ||
|
||
void SeqlockImpl::wait_load(seqlock_version_t& ver, | ||
const void* current_value, | ||
size_t value_size, | ||
void* return_value) const { | ||
while (!try_load_(ver, current_value, value_size, return_value)) { | ||
cpu_relax(); | ||
} | ||
} | ||
|
||
bool SeqlockImpl::try_load_(seqlock_version_t& ver, | ||
const void* current_value, | ||
size_t value_size, | ||
void* return_value) const { | ||
const seqlock_version_t ver0 = AtomicOps::load_relaxed(ver_); | ||
AtomicOps::fence_seq_cst(); | ||
|
||
volatile_copy(return_value, current_value, value_size); | ||
AtomicOps::fence_acquire(); | ||
|
||
ver = AtomicOps::load_relaxed(ver_); | ||
return ((ver0 & 1) == 0 && ver0 == ver); | ||
} | ||
|
||
} // namespace core | ||
} // namespace roc |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* | ||
* Copyright (c) 2020 Roc Streaming authors | ||
* | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
*/ | ||
|
||
//! @file roc_core/seqlock_impl.h | ||
//! @brief Seqlock implementation. | ||
|
||
#ifndef ROC_CORE_SEQLOCK_IMPL_H_ | ||
#define ROC_CORE_SEQLOCK_IMPL_H_ | ||
|
||
#include "roc_core/stddefs.h" | ||
|
||
namespace roc { | ||
namespace core { | ||
|
||
typedef uint32_t seqlock_version_t; | ||
|
||
//! Seqlock implementation. | ||
class SeqlockImpl { | ||
public: | ||
//! Initialize. | ||
SeqlockImpl(); | ||
|
||
//! Load value version. | ||
seqlock_version_t version() const; | ||
|
||
//! Try to store value. | ||
bool try_store(seqlock_version_t& ver, | ||
void* current_value, | ||
size_t value_size, | ||
const void* new_value); | ||
|
||
//! Store value. | ||
void exclusive_store(seqlock_version_t& ver, | ||
void* current_value, | ||
size_t value_size, | ||
const void* new_value); | ||
|
||
//! Try to load value and version. | ||
bool try_load_repeat(seqlock_version_t& ver, | ||
const void* current_value, | ||
size_t value_size, | ||
void* return_value) const; | ||
|
||
//! Load value and version. | ||
void wait_load(seqlock_version_t& ver, | ||
const void* current_value, | ||
size_t value_size, | ||
void* return_value) const; | ||
|
||
private: | ||
bool try_load_(seqlock_version_t& ver, | ||
const void* current_value, | ||
size_t value_size, | ||
void* return_value) const; | ||
|
||
seqlock_version_t ver_; | ||
}; | ||
|
||
} // namespace core | ||
} // namespace roc | ||
|
||
#endif // ROC_CORE_SEQLOCK_IMPL_H_ |