Services integration 2 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes: roc-streaming#1, roc-streaming#16, roc-streaming#17, roc-streaming#66 - Initiate request for notification and microphone permissions and media projection on the dart side of AndroidBackend. - Implement those requests in MainActivity.kt and rework AndroidConnector to redirect those requests to activity. - Automatically stop media projection when both sender and receiver are stopped. Prevent service from stopping projection while we are starting sender and receiver. - Implement synchronization and fix various races. - Use foreground service instead of bound service, to keep it running when app closes. - Forbid swiping away notification on lock screen. (We can forbid it only for lock screen). - Stop sender and receiver when notification is swiped away. - Add AndroidListener, to pass events from kotlin to dart. Implement in in AndroidBackend on dart side. - Add AndroidSenderSettings, AndroidReceiverSettings, and pass them from model to kotlin. - Hard-code ports in model instead of kotlin. - Implement Backend.getLocalAddresses(). - Improve comments. - Refactor android service code. - Remove unused values from strings.xml.
- Merge all kotlin files into on package - Merge kotlin and java directories - SenderReceiverService => StreamingService - android_connector => android_bridge (because it now defines AndroidConnector + AndroidListener) - android_bridge.dart => android_bridge.decl.dart (this file is never imported directly) - screenshot => docs/screenshot/ - tag.py => script/make_tag.py
gavv
force-pushed
the
services_integration2
branch
from
83d0310 to
f9e7226
Compare
- Add NoopBackend and use in tests - Call TestWidgetsFlutterBinding.ensureInitialized() - Make tests async and properly use await
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #98