-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update locks #30
Update locks #30
Conversation
Also checking if this might fix #29 with the following link: |
Thanks so much! Really sorry I haven't gotten back around to this. I see the binder has exploded... not sure why the entropy checking is no good there (it shouldn't need to solve the lock environment in binder). Aside: I'd really be interested in your feedback on other useful keywords... if they are in the wild, #26 would be great place to put them, otherwise issue-per-keyword-family is rad. |
In |
Gah, maybe this is better: add to
|
yeah I've been thinking on how we could use this with other clients such as voila and jupyterlab-classic. Sounds like it would make sense to discuss that in #26 for sure 👍 |
skipping around between multiple tabs is a pretty serious pain to test, but otherwise should be alright. the ideal would be to reuse as much as possible from lab, and have a very thin set of overlay keywords. If you build a lot of new CSS classes... meh. My real goal is to eventually be a bit cleverer, so instead of |
|
sooo.... i haven't been following too closely, but is voila going to support lab3-based federated modules? the use of (or config setup to not need) |
Yeah... it's a bit of an odd beast, and not entirely to my liking... but since we're testing a test environment... normally, i don't install |
Yes, we are planning to make the Voila frontend a lab-based frontend using 3.0 packages, so existing mime renderers and widgets should work out of the box as federated extensions. There are a couple of smaller steps before this (for example moving to TS), but in any case improving on the end-to-end testing should help catch potential issues when making such changes. |
Sorry, I was getting some weird stale state in my browser, and thought some jobs were failing... opened it in another browser, and saw that it was all ✔️ ! Going to take a quick spin around the binder, and very likely merge soon thereafter. Thanks again! |
Update the
lab
environment to use the final versions, and remove therc
channels.