Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*_upper_leg_back_contact frames #42

Open
3 of 4 tasks
traversaro opened this issue Feb 17, 2017 · 11 comments
Open
3 of 4 tasks

*_upper_leg_back_contact frames #42

traversaro opened this issue Feb 17, 2017 · 11 comments

Comments

@traversaro
Copy link
Member

traversaro commented Feb 17, 2017

@gabrielenava defined and added to the simmechanics generated models the (r/l)_upper_leg_contact frames, that are convenient for experiments in which the robot is sitting on its legs. After a day, I suggest to renamed this frames to *_upper_leg_back_contact to avoid confusion.

These frames work fine, but they have been just committed to the robot models contained in yarp-wholebodyinterface , and I will list here the things that need to be addressed to have them properly integrated in the model generation pipeline.

  • Document their location in http://wiki.icub.org/wiki/ICub_Model_naming_conventions#URDF_frames,
  • Add them to Creo model committed in the hardware repository and regenerate the shrinkwraps for the upper_leg links and then regenerate the simmechanics xml,
  • Commit the generated file in icub-model-generator and regenerated all the URDFs ,
  • Copy the generated models in yarp-wholebodyinterface.

cc @DanielePucci

@gabrielenava
Copy link
Contributor

I asked for Mechanical engineers support, and they are aware of this issue and our requirements.

@gabrielenava gabrielenava removed their assignment Aug 28, 2017
@gabrielenava
Copy link
Contributor

gabrielenava commented Sep 7, 2017

The new iCub model contains also the leg contact frames.

@fiorisi
Copy link
Member

fiorisi commented May 4, 2018

Updated the documentation in the wiki. As discussed with @gabrielenava, probably yarp-wholebodyinterface is deprecated, so we can close the issue? Or do we have to copy the models in another location?

@gabrielenava
Copy link
Contributor

related issue: robotology/robotology-superbuild#14

@traversaro
Copy link
Member Author

traversaro commented Aug 23, 2018

I noticed that this frames are not present in the iCubNancy01 model, differently from the version manually patched in https://github.com/robotology/yarp-wholebodyinterface/blob/master/app/robots/iCubNancy01/model.urdf . However, I do not know if anyone is using those frames, as the controllers in whole-body-controllers does not seem to support anymore iCubNancy01, at least judging from the configuration files.

@gabrielenava
Copy link
Contributor

gabrielenava commented Aug 23, 2018

Yes, at the moment the torque controllers only support icubGazeboSim, iCubGazeboV2_5, and iCubGenova02/04. The idea was to port from WBIToolbox-Controllers only the bare essentials in order to keep an ordered and maintainable structure of the repo, and then to add other robots/features only if necessary. I think for the moment we can proceed without iCubNancy01 and if necessary we can add it later. Or should we ask to the Nancy lab?

@traversaro
Copy link
Member Author

cc @DanielePucci

@DanielePucci
Copy link
Contributor

If it takes too long time to generate a no-battery-pack model with these new frames, we may take the iCubGenova02/04 are remove some torso mass to generate the iCubNancy01 model, right?

@traversaro
Copy link
Member Author

The Creo-generated model without backpack (such as the iCubDarmstadt01) already contains this models (but at the moment the iCubNancy01 robot is still generated with the dh parameters hardcoded in the code because it uses arv v1). However, the question was if we want to have iCubNancy01 configuration files for the controllers. If we don't, I think we can deal with this model problem when we will work in adding back the configuration files to the controllers.

@fiorisi
Copy link
Member

fiorisi commented Aug 26, 2018

So probably we can close this issue?

@traversaro
Copy link
Member Author

I prefer to solve the iCubNancy01 problem before closing this issue, see also robotology-legacy/yarp-wholebodyinterface#89 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants