Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing override to getSixAxisForceTorqueSensorMeasure #224

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

traversaro
Copy link
Member

This fixes the clang warning:

2024-12-07T13:50:41.3352070Z /Users/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/plugins/forcetorque/ForceTorqueDriver.cpp:111:18: warning: 'getSixAxisForceTorqueSensorMeasure' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
2024-12-07T13:50:41.3451950Z   111 |     virtual bool getSixAxisForceTorqueSensorMeasure(size_t sens_index,
2024-12-07T13:50:41.3553160Z       |                  ^
2024-12-07T13:50:41.3655370Z /Users/runner/micromamba/envs/gzyarppluginsdev/include/yarp/dev/MultipleAnalogSensorsInterfaces.h:442:18: note: overridden virtual function is here
2024-12-07T13:50:41.3765080Z   442 |     virtual bool getSixAxisForceTorqueSensorMeasure(size_t sens_index, yarp::sig::Vector& out, double& timestamp) const = 0;
2024-12-07T13:50:41.3857210Z       |                  ^
2024-12-07T13:50:41.3958290Z 1 warning generated.

Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traversaro !

@xela-95 xela-95 force-pushed the traversaro-patch-10 branch from eef8890 to ee8e94a Compare December 7, 2024 17:39
@xela-95
Copy link
Member

xela-95 commented Dec 7, 2024

Rebased on main to avoid failing tests in CI due to #222 .

@xela-95 xela-95 merged commit 5fc64d6 into main Dec 7, 2024
11 checks passed
@xela-95 xela-95 deleted the traversaro-patch-10 branch December 7, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants