Skip to content
This repository has been archived by the owner on Jan 7, 2019. It is now read-only.

[ci] Match signedness and type in test to avoid warnings in stm32. #254

Merged
merged 9 commits into from
Jun 28, 2017
Merged

[ci] Match signedness and type in test to avoid warnings in stm32. #254

merged 9 commits into from
Jun 28, 2017

Conversation

strongly-typed
Copy link
Member

Never ran target=stm32 before ...

@salkinium
Copy link
Member

salkinium commented May 12, 2017 •
edited
Loading

Might want to throw in scons unittest too ;-P

@salkinium salkinium added this to the 2017q2 milestone May 12, 2017
@salkinium salkinium self-assigned this May 12, 2017
@strongly-typed
Copy link
Member Author

Will you hate me if I accidentally type in target=atxmega?

 xpcc/ui/gui/widgets/widget.cpp:46:1: warning: all paths through this function will call itself [-Winfinite-recursion]

is already mentioned in #177.

 ./xpcc/communication/xpcc/response_callback.hpp:82:14: warning: 'reinterpret_cast' from class 'TestingComponent2 *' to its base at non-zero offset
  'xpcc::Communicatable *' behaves differently from 'static_cast' [-Wreinterpret-base-class]

Compiler's hint

 note: use 'static_cast' to adjust the pointer correctly while upcasting

is not the solution. It leads to a segfault ..

 ➜  xpcc_feature_release_test git:(fix/release_tests) ✗ lldb ./build/unittest_hosted/executable
 (lldb) target create "./build/unittest_hosted/executable"
 Current executable set to './build/unittest_hosted/executable' (x86_64).
 (lldb) run
 Process 31165 launched: './build/unittest_hosted/executable' (x86_64)
 executable was compiled with optimization - stepping may behave oddly; variables may not be available.
 Process 31165 stopped
 * thread #1: tid = 0x4195d6, 0x000000010001180a executable`xpcc::LinkedList<Timeline::Event,      xpcc::allocator::Dynamic<Timeline::Event> >::append(this=0x0003000000000000, value=<unavailable>) + 48      at linked_list_impl.hpp:104, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (     code=EXC_I386_GPFLT)
     frame #0: 0x000000010001180a executable`xpcc::LinkedList<Timeline::Event, xpcc::allocator::Dynamic<     Timeline::Event> >::append(this=0x0003000000000000, value=<unavailable>) + 48 at      linked_list_impl.hpp:104 [opt]
    101
    102 		// hook the node into the list
    103 		node->next = 0;
 -> 104 		if (this->front == 0)
    105 		{
    106 			// first entry in the list
    107 			this->front = node;

So this might be a tougher one. I do not have enough insight into the xpcc communication judge if the reinterpret cast is a problem.

@salkinium
Copy link
Member

Will you hate me if I accidentally type in target=atxmega?

I'm spending all my hate on myself for having to forward port all this stuff to modm, nothing left for you. Try again next year.
Keep in mind I'm not reviving Xmega it until after modm.

is already mentioned in #177.

… and firmly assigned to @daniel-k, who is firmly ignoring me. It's almost like I have no authority over anything anymore. All y'all have no respect! YOU PUNKS GET OFF MY LAWN!

is not the solution. It leads to a segfault ..

¯\_(ツ)_/¯
cc @dergraaf

@strongly-typed strongly-typed force-pushed the fix/release_tests branch 4 times, most recently from b70e0a5 to 9ccfb1e Compare May 14, 2017 21:44
@salkinium salkinium self-requested a review May 22, 2017 09:22
salkinium
salkinium approved these changes May 26, 2017
View reviewed changes
src/xpcc/architecture/platform/board/nucleo_l476rg/nucleo_l476rg.hpp Outdated
@@ -87,6 +87,9 @@ using Rx = GpioInputA3;
using Uart = Usart2;
}

// Create an IODeviceWrapper around the Uart Peripheral we want to use
using LoggerDevice = xpcc::IODeviceWrapper< Board::stlink::Uart, xpcc::IOBuffer::BlockIfFull >;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to all boards then?

@strongly-typed @salkinium
[tests] Disable float format compare on microcontrollers.
70be4c7
@strongly-typed @salkinium
[tests] Use TEST_ASSERT_EQUAL instead of TEST_ASSERT_TRUE.
97628f3
@strongly-typed @salkinium
[tests] pow(double, int) only returns an approximation without FPU.
a6db58e 
Explicitly convert to double for any operation.
@strongly-typed @salkinium
[tests] ResumableResult<T> may be longer.
d87aad7 
salkinium:
The assumption I made for ResumableResult<T> was that this is an object that lives either on the stack or in registers, but is rarely (never?) placed in memory. Therefore I used a uint_fast8_t to describe the state.
@strongly-typed @salkinium
[tests] Make sure increment is at least 1.
c62fdb9
@strongly-typed @salkinium
[tests] Use TEST_ASSERT_EQUALS_RANGE instead of TEST_ASSERT_TRUE.
4d92183
@strongly-typed @salkinium
[boards] Export logger type so it can be reused.
1dff915
@strongly-typed @salkinium
[tests] Reused logger if the board has one. Add debug logger.
06cfece
@strongly-typed @salkinium
[tests] Add build and git info.
008bfda
@salkinium salkinium merged commit 008bfda into roboterclubaachen:develop Jun 28, 2017
@salkinium
Copy link
Member

Thanks for the good work!

@strongly-typed strongly-typed deleted the fix/release_tests branch October 18, 2017 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@salkinium salkinium salkinium approved these changes

Assignees

@salkinium salkinium

Labels
testing
Projects
None yet
Milestone
2017q2
Development

Successfully merging this pull request may close these issues.
2 participants
@strongly-typed @salkinium