feat(version): release 0.24.8 version

robolaunch · Dec 20, 2023 · fff6d96 · fff6d96
1 parent 4ab5b1d
commit fff6d96
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@
       <img src="https://img.shields.io/badge/nodejs-18.18.2-dgreen" alt="node">
     </a>
     <a href="https://github.com/robolaunch/ui/releases">
-      <img src="https://img.shields.io/badge/release-v0.24.7-red" alt="release">
+      <img src="https://img.shields.io/badge/release-v0.24.8-red" alt="release">
     </a>
         <a href="#">
       <img src="https://img.shields.io/badge/language-typescript-blue" alt="language">

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ui",
-  "version": "0.24.7",
+  "version": "0.24.8",
   "private": true,
   "scripts": {
     "dev": "react-scripts start",

diff --git a/src/contexts/RobotContext.tsx b/src/contexts/RobotContext.tsx
@@ -180,30 +180,30 @@ export default ({ children }: any) => {
 
   // ROS Bridge Connector
   useEffect(() => {
-    if (
+    const rosClient: ROSLIB.Ros | null =
       isSettedCookie &&
       responseRobot?.bridgeIngressEndpoint?.split("://")[0] === "wss" &&
       !envApplication
-    ) {
-      const rosClient: ROSLIB.Ros = new ROSLIB.Ros({
-        url: responseRobot?.bridgeIngressEndpoint,
-      });
+        ? new ROSLIB.Ros({
+            url: responseRobot?.bridgeIngressEndpoint,
+          })
+        : null;
 
-      setRos(ros);
+    setRos(ros);
 
-      rosClient?.on("connection", function () {
-        setIsRosConnected(true);
-      });
-      rosClient?.on("error", function (error) {
-        setIsRosConnected(false);
-      });
-      rosClient?.on("close", function () {
-        setIsRosConnected(false);
-      });
-    }
+    ros?.on("connection", function () {
+      isRosConnected === null && setIsRosConnected(true);
+    });
+    ros?.on("error", function (error) {
+      isRosConnected === null && setIsRosConnected(false);
+    });
+    ros?.on("close", function () {
+      isRosConnected === null && setIsRosConnected(false);
+    });
 
     return () => {
       ros?.close();
+      rosClient?.close();
     };
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [responseRobot, isSettedCookie]);