refactor(connections): 🎉 add ros connection control functions

robolaunch · Dec 20, 2023 · 6af1737 · 6af1737
1 parent 2806011
commit 6af1737
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ui",
-  "version": "0.23.4",
+  "version": "0.23.5",
   "private": true,
   "scripts": {
     "dev": "react-scripts start",

diff --git a/src/components/Connections/Connections.tsx b/src/components/Connections/Connections.tsx
@@ -34,6 +34,10 @@ export default function Connections(): ReactElement {
     } else {
       rosClient?.close();
     }
+
+    return () => {
+      rosClient?.close();
+    };
   }, [
     isRobotReady,
     isSettedCookie,

diff --git a/src/layouts/EnvironmentPageLayout/EnvironmentPageLayout.tsx b/src/layouts/EnvironmentPageLayout/EnvironmentPageLayout.tsx
@@ -2,7 +2,7 @@ import { Fragment, ReactElement } from "react";
 import EnvironmentHeader from "../../components/EnvironmentHeader/EnvironmentHeader";
 import HiddenFrame from "../../components/HiddenFrame/HiddenFrame";
 import { envApplication } from "../../helpers/envProvider";
-import RosConnector from "../../components/RosConnector/RosConnector";
+// import RosConnector from "../../components/RosConnector/RosConnector";
 import Overview from "../../pages/EnvironmentPage/Overview/Overview";
 import MissionContext from "../../contexts/MissionContext";
 import BarcodeContext from "../../contexts/BarcodeContext";
@@ -24,7 +24,7 @@ export default function EnvironmentPageLayout(): ReactElement {
     <Fragment>
       <div className="flex h-full flex-col gap-6">
         <EnvironmentHeader />
-        {!envApplication && <RosConnector />}
+        {/* {!envApplication && <RosConnector />} */}
 
         {(() => {
           switch (activeTab) {